For the record, this is what the upsell_add_sc_select() function is outputting, which looks fine to me:
<select id="upsell_add_select"><option>Upsell Ads</option><option value="[upsellad id=1]">Ad #1</option><option value="[upsellad id=2]">Ad #2</option></select>